dgb: bootstrap src/impl/dgb skeleton (M2) - #60
Merged
Conversation
Scrypt-only V36 coin module scaffold per c2pool-dgb-embedded-impl-plan.md (8ef8d2d). Mirrors src/impl/btc layout: coin/ + daemon/ + test/ slices, -DCOIN_DGB=ON build gate (guarded, not yet registered top-level). - coin/header_chain.hpp: Scrypt-only validation point; non-Scrypt algos accept-by-continuity, full 5-algo deferred to V37. DigiShield insertion pt. - coin/template_builder.hpp: GBT rules=[scrypt]; p2pool-merged-v36 parity pt. - daemon/README.txt: embedded DigiByte Core slice scope (no in-tree vendor). - test/README.txt: Scrypt fixtures + multi-algo accept-by-continuity + parity. Preserves pre-existing config_coin/config_pool/node stubs. No -DAUX_DOGE (stretch parked behind Phase 5.8). Per-coin isolation held: src/impl/dgb only. Scope: M2 structural skeleton only. node.cpp + share commit/validation wiring (and Scrypt-only template-builder fill + DigiShield finalization) land in M3. Mirrors bch M2 bootstrap discipline.
…tor-only DigiShield note into header_chain.hpp stub (PR #60, M3 prereq)
- Drop empty src/impl/dgb/coin/CMakeLists.txt (referenced only by a commented-out add_subdirectory(coin) in src/impl/dgb/CMakeLists.txt; bch carries none). Parity cleanup, no build impact. config_coin.hpp NOT added: src/impl/dgb/config_coin.hpp already exists on master (tracked, unmodified by this PR -> absent from the diff view) and already defines CoinParams::GBT_ALGO = "scrypt". template_builder.hpp reference is satisfied, not dangling. Per bch-embedded-steward review (UID 632); no scope expansion.
This was referenced Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M2:
src/impl/dgbskeleton — DGB Scrypt-only V36 coin moduleStructural bootstrap of the DGB Scrypt-only coin module, following the approved M1 implementation plan
c2pool-dgb-embedded-impl-plan.md(frstrtr/the docs, 8ef8d2d). V36 ratification context:project_v36_dgb_scrypt_only.Scope: M2 structural skeleton only.
node.cpp+ share commit/validation wiring, Scrypt-only template-builder fill, and DigiShield finalization land in M3. Mirrors the bch M2 bootstrap discipline.Per-coin isolation invariant
src/impl/dgb/only — nosrc/core/orbitcoin_family/touches.-DAUX_DOGEplumbing (the dual-parent stretch / §X is parked behind Phase 5.8; ltc-doge owns the shared DOGE-aux surface).origin/master: 6 files, all undersrc/impl/dgb/.CMake registration held
CMakeLists.txtchange in this PR. Theif(COIN_DGB)guard lives insidesrc/impl/dgb/CMakeLists.txt(message-only at M2;coin/,daemon/,test/subdirs commented out).add_subdirectory(src/impl/dgb)registration is held until ci-steward's PR-CMake-object-library convention lands;impl_dgbregisters as 1 of 5 per-coin OBJECT libs at that point (M3).Files (6)
coin/header_chain.hpp— Scrypt-only validation point; non-Scrypt algos accept-by-continuity (full 5-algo deferred to V37); DigiShield insertion point.coin/template_builder.hpp— GBTrules=[scrypt]; p2pool-merged-v36 parity point.daemon/README.txt— embedded DigiByte Core slice scope (no in-tree vendor).test/README.txt— Scrypt fixtures + multi-algo accept-by-continuity + parity outline.CMakeLists.txt(+coin/CMakeLists.txt) —-DCOIN_DGB=ONbuild gate, guarded.Requested reviewers
bch/bootstrap-skeleton).if(COIN_DGB)must compose with the forthcoming convention).